fix: FeatureTestTrait::withRoutes() may throw all sorts of errors on invalid HTTP methods#10004
Merged
paulbalandan merged 2 commits intocodeigniter4:developfrom Feb 25, 2026
Conversation
paulbalandan
added
the
bug
Member
Author
|
Installing ImageMagick on PHP 8.4 is taking too long. 🤔 |
michalsn
approved these changes
Feb 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Per documentation,
withRoutes()accepts a list of 3 to 4 element arrays where the first element is the HTTP verb (or the specialaddto mean all verbs). However, there's no validation for invalid methods and is just directly called uponRouteCollectionwhich may result in unknown method, TypeError for parameter, etc.Checklist: